[Bug 1895766] Review Request: ansible-pcp - Ansible Metric collection for Performance Co-Pilot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1895766



--- Comment #2 from Rich Megginson <rmeggins@xxxxxxxxxx> ---
> - I'm not 100% sure if the .galaxy_install_info files should be there in every role/meta folder - it contains an "install_date" and a version which is set to "0.0.1" (which doesn't match the package version). Can you verify if this file should be in the RPM?

You can probably get rid of _all_ dotfiles/dot-directories from the package. 
They are not needed by ansible.

> - It would be great if tests run as part of the %check, but I assume that's not possible due to the nature of the package? I.e. it would require a VM or container to perform tests of the ansible roles?

You could probably run unit tests, linters, etc. - but no tests that actually
run ansible - and no molecule.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux