https://bugzilla.redhat.com/show_bug.cgi?id=1891336 --- Comment #4 from Micah Shennum <jimtahu@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #3) > - No test suite here? > > %check > pushd .%{gem_instdir} > # Run the test suite. > popd >From what I could find, there was not a test suite back in the 2.2.5 version, or rather I could not figure out how to run it. Removed the dead check section. > - Release should start at 1 > > Release: 0%{?dist} Done > - Should use the BSD shorthand: > > License: BSD Done Spec URL: https://download.copr.fedorainfracloud.org/results/jimtahu/tmuxinator/fedora-rawhide-x86_64/01756741-rubygem-xdg/rubygem-xdg.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jimtahu/tmuxinator/fedora-rawhide-x86_64/01756741-rubygem-xdg/rubygem-xdg-2.2.5-1.fc34.src.rpm Also checked spec into pagure.io at https://pagure.io/rubygem-xdg/blob/master/f/rubygem-xdg.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx