Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: eboard - ICS chess board interface https://bugzilla.redhat.com/show_bug.cgi?id=338681 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-07 12:08 EST ------- Builds OK, although I have to admit I don't understand why you change -O6 into -O2 in the configure script, then run it, then change -O2 to %{optflags} in the generated makefile. But it's not like it matters. Is there any upstream at all for this software? The spec has no URL: tag, and Source0: isn't a URL either. I'm guessing that a proper URL: would be "http://www.bergo.eng.br/eboard/"; and Source0: should be "http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2";. rpmlint says: eboard.x86_64: E: standard-dir-owned-by-package /usr/share/man/man6 eboard.x86_64: E: standard-dir-owned-by-package /usr/share/man/man1 Definite blocker here; the package should not own these directories. eboard.x86_64: W: devel-file-in-non-devel-package /usr/bin/eboard-config I'm not sure what the point of the -config script is since there aren't any libraries or headers, but I think it would be pointless to make a -devel package just for it. Still, do you know what this is used for? It doesn't supply any useful information, and the --datadir output seems actively wrong (should be /usr/share/eboard, I'd think, but it's just /usr/share). eboard.x86_64: W: summary-not-capitalized eboard chess board interface There's not usually any need to include the package name in the Summary: since "eboard - eboard chess board interface" is a bit redundant. eboard.x86_64: E: no-description-tag You definitely need something in your %description. eboard.x86_64: W: no-version-in-last-changelog See the "Changelogs" section of http://fedoraproject.org/wiki/Packaging/Guidelines for the proper changelog formats. eboard.x86_64: W: no-url-tag Should at least point to the upstream website. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review