https://bugzilla.redhat.com/show_bug.cgi?id=1895833 Sandro Mani <manisandro@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|needinfo?(manisandro@gmail. | |com) | --- Comment #2 from Sandro Mani <manisandro@xxxxxxxxx> --- - Please document the license breakdown - You don't need noarch in the subpackages as the main package is noarch - There are unowned directories - include the directories directly, not the files within - You need to BR cmake and pretty soon also make explicitly Proposed changes: --- a/mingw-adwaita-qt.spec +++ b/mingw-adwaita-qt.spec @@ -13,6 +13,9 @@ Source0: https://github.com/FedoraQt/adwaita-qt/archive/%{version}/adwait BuildArch: noarch +BuildRequires: cmake +BuildRequires: make + BuildRequires: mingw32-filesystem >= 95 BuildRequires: mingw32-gcc BuildRequires: mingw32-gcc-c++ @@ -30,7 +33,6 @@ Theme to let Qt applications fit nicely into Fedora Workstation %package -n mingw32-adwaita-qt5 Summary: Adwaita Qt5 theme Requires: mingw32-libadwaita-qt5 = %{version}-%{release} -BuildArch: noarch %description -n mingw32-adwaita-qt5 Adwaita theme variant for applications utilizing Qt5. @@ -52,7 +54,6 @@ Static version of the mingw32-libadwaita-qt5 library. %package -n mingw64-adwaita-qt5 Summary: Adwaita Qt5 theme Requires: mingw64-libadwaita-qt5 = %{version}-%{release} -BuildArch: noarch %description -n mingw64-adwaita-qt5 Adwaita theme variant for applications utilizing Qt5. @@ -92,8 +93,8 @@ Static version of the mingw64-libadwaita-qt5 library. %files -n mingw32-libadwaita-qt5 %{mingw32_bindir}/libadwaitaqt-1.dll %{mingw32_bindir}/libadwaitaqtpriv-1.dll -%{mingw32_includedir}/AdwaitaQt/*.h -%{mingw32_libdir}/cmake/AdwaitaQt/*cmake +%{mingw32_includedir}/AdwaitaQt/ +%{mingw32_libdir}/cmake/AdwaitaQt/ %{mingw32_libdir}/pkgconfig/adwaita-qt.pc %files -n mingw32-libadwaita-qt5-static @@ -107,8 +108,8 @@ Static version of the mingw64-libadwaita-qt5 library. %files -n mingw64-libadwaita-qt5 %{mingw64_bindir}/libadwaitaqt-1.dll %{mingw64_bindir}/libadwaitaqtpriv-1.dll -%{mingw64_includedir}/AdwaitaQt/*.h -%{mingw64_libdir}/cmake/AdwaitaQt/*cmake +%{mingw64_includedir}/AdwaitaQt/ +%{mingw64_libdir}/cmake/AdwaitaQt/ %{mingw64_libdir}/pkgconfig/adwaita-qt.pc %files -n mingw64-libadwaita-qt5-static Scratch build with proposed changes: https://koji.fedoraproject.org/koji/taskinfo?taskID=55265362 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
