[Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC


https://bugzilla.redhat.com/show_bug.cgi?id=361211





------- Additional Comments From sseago@xxxxxxxxxx  2007-11-07 11:56 EST -------
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64 
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent

OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch

??? - BuildRoot value: not sure if this is really a problem, but it
  looks like %{release} is omitted:

  BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
 vs.
             %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

FIX - RUNNING_UNIT_TESTS not installed as %doc
  general doc question: docs are installed as doc in
  %{_docdir}/%{name}-%{version} but still included as regular gem
  files in %{geminstdir} -- should they be in one place or the other
  but not both? Is there a clear preference (some of the other rubygem
  packages -- both yours and mine include the doc in the gem, not in /usr/share/doc

FIX - rpmlint complains 
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.rbx
0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/blog_controller.cgi 0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/debate_controller.cgi 0644
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/app/controllers/admin/user_controller.rb
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.cgi
0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/benchmark_with_ar.fcgi 0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/lib/action_controller/session/drb_server.rb
0644
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/vendor/plugins/bad_plugin/lib/plugin_controller.rb
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/app/controllers/user_controller.rb
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.fcgi
0644


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]