Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ski - IA-64 user and system mode simulator https://bugzilla.redhat.com/show_bug.cgi?id=321411 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-07 11:02 EST ------- You missed a bunch of rpmlint complaints: ski.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libski-1.2.so.6.0.0 /usr/lib64/libelf.so.1 ski.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libski-1.2.so.6.0.0 /lib64/libncurses.so.5 The libski-1.2.so is linked against those two libraries even though it doesn't call any functions in them. ski.x86_64: W: undefined-non-weak-symbol /usr/lib64/libski-1.2.so.6.0.0 force_user ski.x86_64: W: undefined-non-weak-symbol /usr/lib64/libski-1.2.so.6.0.0 userint ski.x86_64: W: undefined-non-weak-symbol /usr/lib64/libski-1.2.so.6.0.0 sim_root_len ski.x86_64: W: undefined-non-weak-symbol /usr/lib64/libski-1.2.so.6.0.0 sim_root and over 300 more similar messages. The library calls those functions, but isn't linked against any library which provides them. Otherwise I think this package looks OK, but I don't know enough about the software to know to know if the above issues are problematic. I suspect that the unused-direct-shlib-dependency warnings are merely inefficiencies (libraries pulled in when they're not needed) and that the undefined-non-weak-symbols are provided by libraries which are linked into the executables which also link against libski-1.2.so. Still, this package included a -devel subpackage indicating that libski might be used separately from its executables, and so the library should actually be linked against the libraries it needs if possible. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review