[Bug 1893901] Review Request: ansible-base - A radically simple IT automation system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1893901

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #5 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
(In reply to Kevin Fenzi from comment #4)
> I'm fine removing all the .git_keep and .travis.yml, but these two I think
> are used by ansible_test:
> 
> > /usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc
> > ansible-base.noarch: E: zero-length
> > /usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg
> > ansible-base.noarch: E: zero-length
> 

Sure!

>  >  - Please don't forget to clean the Sphinx build leftovers here
> > 
> > %if 0%{?with_docs}
> >   make PYTHON=/usr/bin/python3 SPHINXBUILD=sphinx-build-3 webdocs
> > %else
> 
> Can you expand on what build leftovers should be cleaned? Is there a
> guideline?
> 
Sphinx building leaves hidden files that should be removed:

# remove the sphinx-build leftovers
rm -rf docs/docsite/_build/html/.{doctrees,buildinfo}

Although you don't build the doc, I think this shoild be added for the future.


Package approved.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux