[Bug 1893538] Review Request: python-bashate - pep8 equivalent for bash scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1893538



--- Comment #2 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
>  - Use:
> 
> Source0:        %{pypi_source}

Changed

>  - Not sure you should provide bashate/tests Usually tests are remvoved in
> %install

I changed the spec to have a %exclude in %files so tests can be done but part
of the final rpm. Is this acceptable? If not, is there any example I can check?

>  - Remove the shebang:
> 
> python3-bashate.noarch: E: non-executable-script
> /usr/lib/python3.9/site-packages/bashate/bashate.py 644 /usr/bin/env python

Done


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux