https://bugzilla.redhat.com/show_bug.cgi?id=1893901 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > These are harmless I think: ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/.travis.yml ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/.travis.yml ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/roles/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/.travis.yml ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/.travis.yml ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep ansible-base.noarch: W: hidden-file-or-dir /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible_test/_data/coveragerc ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible_test/_data/ansible.cfg ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/templates/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/network/files/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/templates/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/role/files/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/roles/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/default/collection/docs/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/templates/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/container/files/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/templates/.git_keep ansible-base.noarch: E: zero-length /usr/lib/python3.9/site-packages/ansible/galaxy/data/apb/files/.git_keep Please remove them. - Would prefer you use %bcond_with/%bcond_without %global with_tests 1 - Please document why this patch is needed: Patch1: 2.10.3-test-patch.patch - Please don't forget to clean the Sphinx build leftovers here %if 0%{?with_docs} make PYTHON=/usr/bin/python3 SPHINXBUILD=sphinx-build-3 webdocs %else - manpages should not be marked as %doc: %{_mandir}/man1/ansible* - that don't work for whole dir, use: %dir %{_sysconfdir}/ansible/ %config(noreplace) %{_sysconfdir}/ansible/* - What the point of this: cp -pr docs/docsite/rst . %if 0%{?with_docs} cp -pr docs/docsite/_build/html %{_builddir}/%{name}-%{version}/html %endif You could directly include the docs with: %files -n ansible-base-doc %doc docs/docsite/rst %if 0%{?with_docs} %doc docs/docsite/_build/html %endif -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx