[Bug 1890891] Review Request: ptex - Per-Face Texture Mapping for Production Rendering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1890891



--- Comment #2 from Luya Tshimbalanga <luya_tfz@xxxxxxxxxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - Should not be needed
> 
> # Force out of source build
> %global __cmake_in_source_build 0
> 
>  - Missing isa for arch:
> 
Removed.


> %package devel
> Summary: Development files for the Ptex library
> Requires: %{name}%{?_isa} = %{version}
> 

Fixed

>  - This doesn't look right: the .so file should go in the devel package and
> you should have a versioned so file in the main package. IF upstream doesn't
> provide a versioned so file you should ask them to do so. If they refuse,
> you should version it downstream.
> 
> %files
> %doc src/doc/README 
> %license src/doc/License.txt
> %{_bindir}/ptxinfo
> %{_libdir}/*so

%{_libdir}/*so is moved to devel package. Unfortunately the packaging guideline
failed to provide the step to set up a versioned .so files.
Meanwhile, the request is filed upstream https://github.com/wdas/ptex/issues/54

Updated
SPEC:
https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01748610-ptex/ptex.spec
SRPM:
https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01748610-ptex/ptex-2.3.2-2.fc34.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux