https://bugzilla.redhat.com/show_bug.cgi?id=1893327 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Not needed BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - Not needed: rm -rf %{buildroot} %clean rm -rf %{buildroot} %defattr(-,root,root,-) - Should this bash script be noreplace? Does the end user reed to edit it for sone reason? %config(noreplace) /etc/profile.d/human-theme-gtk.sh - Same as before: there is no 1.1.0 on Github to be downloaded. - For Requires, you're upstream so you should know what's required? I believe Murrine should be required as it won't work without it and the rest should be recommended: Requires: gtk-murrine-engine Recommends: gnome-icon-theme Recommends: dmz-cursor-themes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx