https://bugzilla.redhat.com/show_bug.cgi?id=1895549 Bug ID: 1895549 Summary: Review Request: seadrive-gui - GUI part of Seafile Drive client Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: alebastr89@xxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Target Milestone: --- Classification: Fedora Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/seafile-client/fedora-rawhide-x86_64/01748406-seadrive-gui/seadrive-gui.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/seafile-client/fedora-rawhide-x86_64/01748406-seadrive-gui/seadrive-gui-2.0.7-0.1.fc34.src.rpm COPR URL: https://copr.fedorainfracloud.org/coprs/alebastr/seafile-client/ Description: This package contains the GUI part of Seafile Drive client. The Drive client enables you to access files on the server without syncing to local disk. Fedora Account System Username: alebastr Review notes: Apparently there is no strict dependency between daemon and gui versions and it's safe to ship mismatched versions. I pinged upstream to confirm. -DCMAKE_BUILD_TYPE=Release is needed to turn off extra debugging functionality of the client. Unbundling QtAwesome is not possible as it is modified and does not match upstream sources. Unbundling fontawesome-fonts would require major rewriting of parts of QtAwesome. Also, the QtAwesome version vendored to seadrive-gui is using fontawesome 3.x which is not completely compatible with either 4.x we have in Fedora or 5.x. I'll revisit that later, when I have more time to deal with these bundled sources. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx