https://bugzilla.redhat.com/show_bug.cgi?id=1887709 --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- Tips for your libsmf spec: - Not used if Fedora Group: Applications/Multimedia Group: Development/Libraries - Use make instead of %{__make} as __ macro are reserved for rpm private use - Not needed: %{__rm} -rf %{buildroot} %clean %{__rm} -rf %{buildroot} %defattr(-,root,root,-) - %{__make} DESTDIR=%{buildroot} install → %make_install - %{__make} %{_smp_mflags} → %make_build - Do not put another %{__make} DESTDIR=%{buildroot} install in %build - COPYING must be installed with %license not %doc in %files - Do not glob all that, be more specific %{_bindir}/* %{_libdir}/* %{_datadir}/man/* %files devel %{_includedir}/* - Requires needs arch info with isa: Requires: %{name}%{?_isa} = %{version}-%{release} - Use a more descriptive summary - Description must be below 80 characters per line. - Add a newline between your changelog entries )Make a separate review request for that package) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
