https://bugzilla.redhat.com/show_bug.cgi?id=1885430 --- Comment #12 from Carl George 🤠 <carl@xxxxxxxxxx> --- > app -> openssl:libcrypto_EVP -> qat_engine -> qat_lib -> openssl:libcrypto_EVP -> qat_engine -> qat_lib -> REPEAT I still don't understand this, but I'm admittedly not a crypto expert. Regardless, if it's only possible for this to function with bundled libcrypto, it is permissible for the package to do that. We've got the bundled library provides in place, so we are covered. > I checked again and the guideline is to still leave the license on the file. In order to address the noise/visual clutter in the file we replaced the full header with the SPDX License Identifier: `# SPDX-License-Identifier: MIT` > Is this ok? It's still redundant, but it's a big improvement and I'll take it. > Thanks. I haven't run the build yet any alternative architectures. Is it something I have to do? If yes, which architectures should I try? When you build the package in Fedora it will attempt to build on all architectures, unless they are excluded. I took your copr srpm and submitted it as a scratch build in Fedora's build system with this command: koji build --scratch rawhide qatlib-20.08.0-1.fc34.src.rpm Here is the result where you can see all the architectures it attempted to build: https://koji.fedoraproject.org/koji/taskinfo?taskID=55010398 Based on that, I think the appropriate exclusion will look like this: ExcludeArch: %{arm} aarch64 %{power64} s390x Remember after review you'll need to open bugzillas for each of those, mark them as blocking the tracker bugs listed in the guidelines [0], and include links to each of them in spec file comments. Other than that slight adjustment to the ExcludeArch tag, I think this looks good. I'm running fedora-review on it now. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
