[Bug 1880721] Review Request: hydroxide - A third-party, open-source ProtonMail bridge

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1880721

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #3 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - I prefer:

sed -i 's|golang.org/x/crypto|github.com/ProtonMail/crypto|' $(find . -name
*.go)

to match the rest of Go packages.

 - the spec file name must match the name of the spec: hydroxide.spec

 - Build fails:

# github.com/emersion/hydroxide/protonmail
_build/src/github.com/emersion/hydroxide/protonmail/contacts.go:167:66: too
many arguments in call to openpgp.CheckArmoredDetachedSignature
        have (openpgp.KeyRing, *bytes.Buffer, io.Reader, nil)
        want (openpgp.KeyRing, io.Reader, io.Reader)
_build/src/github.com/emersion/hydroxide/protonmail/contacts.go:193:55: too
many arguments in call to openpgp.CheckArmoredDetachedSignature
        have (openpgp.KeyRing, *strings.Reader, *strings.Reader, nil)
        want (openpgp.KeyRing, io.Reader, io.Reader)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:39:21:
subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or
method KeyExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:56:137:
i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or
method SigExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:73:21:
subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or
method KeyExpired)
_build/src/github.com/emersion/hydroxide/protonmail/crypto.go:87:80:
i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or
method SigExpired)
_build/src/github.com/emersion/hydroxide/protonmail/srp.go:45:41: too many
arguments in call to openpgp.CheckDetachedSignature
        have (openpgp.EntityList, *bytes.Reader, io.Reader, nil)
        want (openpgp.KeyRing, io.Reader, io.Reader)


Seems the commit you packaged for ProtonMail/crypto
https://github.com/ProtonMail/crypto/commit/5c72a883971a4325f8c62bf07b6d38c20ea47a6a
has been yanked from any branch.

Build is successful after building the latest git commit for ProtonMail/crypto


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Please fix the aforementioned issue.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux