https://bugzilla.redhat.com/show_bug.cgi?id=1892096 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > FIX: Move file LICENSE from %doc to %license > %license LICENSE Done. > Description is almost ok > FIX: Please remove 'E.g.,' from end of description Done. > BuildRequires > FIX: Please add following build-requires. > coreutils - needs for macro %{_fixperms} > make - needs for macros %{make_*} > FIX: Use 'perl(:VERSION) >= 5.10.0' instead of 'perl >= 5.010000' because > the package has an epoch. Done. > FIX: Add build-requires 'perl-generators' to get correct list of run-time > requires and provides. Then you can remove all 'Requires:' except > MODULE_COMPAT. > Lots of listed dependencies are used only for tests during the build. $ rpm -qp --requires perl-Test-Some-0.2.1-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl-interpreter 1 perl(List::MoreUtils) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Package::Stash) 1 perl(strict) 1 perl(Test::More) 1 perl(:VERSION) >= 5.10.0 1 perl(warnings) Binary requires are ok. $ rpm -qp --provides perl-Test-Some-0.2.1-1.fc34.noarch.rpm | sort | uniq -c 1 perl(Test::Some) = 0.2.1 1 perl-Test-Some = 0.2.1-1.fc34 Binary provides are ok. > FIX: Please remove the following old code which is not needed for Fedoras > and EPEL 7/8 Done. > FIX: Remove options 'INSTALLVENDORLIB=/usr/share/perl5/vendor_perl > INSTALLVENDORMAN3DIR=/usr/share/man/man3' > from command 'perl Makefile.PL', they are not needed. Done. > TODO: Use new %make_* macros and remove packlist by ExtUtils::MakeMaker's variable. Done. FIX: Only add version constrain to 'ExtUtils::MakeMaker >= 6.76', NO_PACKLIST was added in this version. FIX: Add missing test build-require perl(blib) - Test-Some-0.2.1/t/00-compile.t:19 The package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
