https://bugzilla.redhat.com/show_bug.cgi?id=1891040 Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(kwizart@xxxxxxxxx | |) | --- Comment #6 from Nicolas Chauvet (kwizart) <kwizart@xxxxxxxxx> --- Hello Davide, Michel, Thanks for looking into this. Wdt seems to assume folly to be built in a "sister directory" from the source tree, so it looks like there is "some amount of work" to switch to use a system folly. I'm not sure to be able to work on such feature by the end of the month due to daily work. Building as shared lib looks possible, but this affect both folly and wdt, so if building with shared, there is probably a need to unbundle folly first. For tests, there is a need to build them in the first step, but they are failing. I've managed, to build them locally, but not on koji as apparently using BUILD_TESTING=ON expect to have internet access in order to download from gtest git. Once downloaded I've made few compilation fixes See also https://github.com/facebook/wdt/pull/210 I've also fixed an issue with gtest locally, but eventually this could be fixed by https://github.com/facebook/wdt/pull/210 (not tested). All in all, seems it will be difficult to contine with this submittion, it might be easier to withdraw this review request so you can continue with a new submission. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
