https://bugzilla.redhat.com/show_bug.cgi?id=1780885 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@xxxxxxxxxxxxxxx Flags| |fedora-review? | |needinfo?(raineforest@raine | |forest.me) --- Comment #4 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Taking this review. This doesn't currently build as is, could you follow the steps here to adjust for Fedora 33's recent CMake changes? https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Also bump the version packaged, since 2.13 is now out. Agreed with previous commenters that: - %find_lang will find the translation files - try starting with only either two packages for now (cutelyst and cutelyst-devel), or three (if the binaries are not needed by running apps and can be packaged separately). Those will be easier to maintain - see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package for having cutelyst-devel requires the right architecture for cutelyst (what Michael Schwendt was referring to) You enabled building tests, but they were never run. Add %check %ctest after the %install section, this should run them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
