https://bugzilla.redhat.com/show_bug.cgi?id=1810293 --- Comment #12 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks pretty good: - Please add comments about the upstream patches, with their URLs (without them, it's hard for a reader to see where these come from or what they do). - Please remove the License tag from the doc sub-package, - Please remove the /usr/include/sdsl/.gitignore file You cannot include the sdsl-lite bits in this package and provide it in the -devel subpackage, each srpm/package should only provide one software, no? sdsl-lite needs to be either: - packaged separately and included as a BR, - or bundled, but then it should not provide the publicly usable headers in this package, Cheers! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
