https://bugzilla.redhat.com/show_bug.cgi?id=1892096 --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok FIX: Move file LICENSE from %doc to %license %license LICENSE Description is almost ok FIX: Please remove 'E.g.,' from end of description URL and Source0 are ok All tests passed BuildRequires FIX: Please add following build-requires. coreutils - needs for macro %{_fixperms} make - needs for macros %{make_*} FIX: Use 'perl(:VERSION) >= 5.10.0' instead of 'perl >= 5.010000' because the package has an epoch. $ rpm -qp --requires perl-Test-Some-0.2.1-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl >= 5.010000 1 perl(ExtUtils::MakeMaker) 1 perl(File::Spec) 1 perl-interpreter 1 perl(IO::Handle) 1 perl(IPC::Open3) 1 perl(List::MoreUtils) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Package::Stash) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::More) 1 perl(warnings) FIX: Add build-requires 'perl-generators' to get correct list of run-time requires and provides. Then you can remove all 'Requires:' except MODULE_COMPAT. Lots of listed dependencies are used only for tests during the build. $ rpm -qp --provides perl-Test-Some-0.2.1-1.fc34.noarch.rpm | sort | uniq -c 1 perl-Test-Some = 0.2.1-1.fc34 FIX: 'perl(Test::Some) = 0.2.1' is missing. Using of perl-generators solve it. $ rpmlint ./perl-Test-Some* perl-Test-Some.noarch: W: spelling-error %description -l en_US subtest -> subtlest, sub test, sub-test perl-Test-Some.noarch: W: spelling-error %description -l en_US whitelist -> white list, white-list, whistle perl-Test-Some.noarch: W: spelling-error %description -l en_US subtests -> sub tests, sub-tests, subtexts perl-Test-Some.src: W: spelling-error %description -l en_US subtest -> subtlest, sub test, sub-test perl-Test-Some.src: W: spelling-error %description -l en_US whitelist -> white list, white-list, whistle perl-Test-Some.src: W: spelling-error %description -l en_US subtests -> sub tests, sub-tests, subtexts 2 packages and 1 specfiles checked; 0 errors, 6 warnings. Rpmlint is ok FIX: Please remove the following old code which is not needed for Fedoras and EPEL 7/8 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) rm -rf %{buildroot} find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';' %clean rm -rf %{buildroot} %defattr(-,root,root,-) FIX: Remove options 'INSTALLVENDORLIB=/usr/share/perl5/vendor_perl INSTALLVENDORMAN3DIR=/usr/share/man/man3' from command 'perl Makefile.PL', they are not needed. TODO: Use new %make_* macros and remove packlist by ExtUtils::MakeMaker's variable. 1) Add NO_PERLLOCAL=1 NO_PACKLIST=1 to command perl Makefile.PL and remove find %{buildroot} -type f -name .packlist -exec rm -f {} ';' 2) Replace make %{?_smp_mflags} by %{make_build} 3) Replace make pure_install PERL_INSTALL_ROOT=%{buildroot} by %{make_install} Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
