[Bug 1893562] Review Request: golang-github-muesli-crunchy - Finds common flaws in passwords

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1893562



--- Comment #1 from Olivier Lemasle <o.lemasle@xxxxxxxxx> ---
Tests fail in mock.
Actually, I do not understand why tests were not executed in your Koji scratch
build... I also launched a scratch build
(https://koji.fedoraproject.org/koji/taskinfo?taskID=54771110); tests were
executed and failed.

- Test TestRatePassword fail because /usr/share/dict is empty in mock. I
suppose this package should depend on package "words", it it expects a
dictionary.
- Test TestCheckHIBP fail because there's no Internet access in mock. This
tests should be disabled.

Test failure messages:

--- FAIL: TestRatePassword (0.00s)
    crunchy_test.go:97: Expected rating 0 for password 'password', got 20
    crunchy_test.go:100: Expected Password is too common / from a dictionary
for password 'password', got <nil>
    crunchy_test.go:97: Expected rating 0 for password 'intoxicate', got 22
    crunchy_test.go:100: Expected Password is too common / from a dictionary
for password 'intoxicate', got <nil>
    crunchy_test.go:97: Expected rating 0 for password 'p@ssw0rd', got 42
    crunchy_test.go:100: Expected Password is mangled, but too common / from a
dictionary for password 'p@ssw0rd', got <nil>
    crunchy_test.go:97: Expected rating 0 for password '!pass@word?', got 64
    crunchy_test.go:100: Expected Password is mangled, but too common / from a
dictionary for password '!pass@word?', got <nil>
    crunchy_test.go:97: Expected rating 0 for password 'drowssap', got 20
    crunchy_test.go:100: Expected Password is mangled, but too common / from a
dictionary for password 'drowssap', got <nil>
    crunchy_test.go:97: Expected rating 0 for password '?drow@ssap!', got 64
    crunchy_test.go:100: Expected Password is mangled, but too common / from a
dictionary for password '?drow@ssap!', got <nil>
    crunchy_test.go:97: Expected rating 0 for password
'5f4dcc3b5aa765d61d8327deb882cf99', got 100
    crunchy_test.go:100: Expected Password is hashed, but too common / from a
dictionary for password '5f4dcc3b5aa765d61d8327deb882cf99', got <nil>
    crunchy_test.go:97: Expected rating 0 for password
'5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8', got 100
    crunchy_test.go:100: Expected Password is hashed, but too common / from a
dictionary for password '5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8', got <nil>
    crunchy_test.go:97: Expected rating 0 for password
'5e884898da28047151d0e56f8dc6292773603d0d6aabbdd62a11ef721d1542d8', got 100
    crunchy_test.go:100: Expected Password is hashed, but too common / from a
dictionary for password
'5e884898da28047151d0e56f8dc6292773603d0d6aabbdd62a11ef721d1542d8', got <nil>
    crunchy_test.go:97: Expected rating 0 for password
'b109f3bbbc244eb82441917ed06d618b9008dd09b3befd1b5e07394c706a8bb980b1d7785e5976ec049b46df5f1326af5a2ea6d103fd07c95385ffab0cacbc86',
got 100
    crunchy_test.go:100: Expected Password is hashed, but too common / from a
dictionary for password
'b109f3bbbc244eb82441917ed06d618b9008dd09b3befd1b5e07394c706a8bb980b1d7785e5976ec049b46df5f1326af5a2ea6d103fd07c95385ffab0cacbc86',
got <nil>
--- FAIL: TestCheckHIBP (0.00s)
    crunchy_test.go:117: Expected Password has been found inside
haveibeenpwned.com database for password 'Qwertyuiop', got Get
"https://api.pwnedpasswords.com/range/21052": dial tcp: lookup
api.pwnedpasswords.com: Temporary failure in name resolution


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux