Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: proxyknife - Customizable multithreaded proxy hunter https://bugzilla.redhat.com/show_bug.cgi?id=322091 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-11-06 18:03 EST ------- Everything looks good to me. The only problem I see is that the info file corrupts the directory with the extra string "This is proxyknife.info, produced by makeinfo version 4.11 from proxyknife.texi." But that's not unique to this package; gnuplot does it as well. I don't know enough about info to say how you'd fix it. * source files match upstream: 622d7117f14175683551f9004b6f9713d3c0352470c0b2dce926c765c2e63e71 proxyknife-1.7.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: config(proxyknife) = 1.7-1.fc8 proxyknife = 1.7-1.fc8 = /bin/sh /sbin/install-info config(proxyknife) = 1.7-1.fc8 * %check is not present; no test suite upstream. I installed the package and it seems to run, although I have no proxies to test it against. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * locale files present; %find_lang used properly. * scriptlets OK: install-info * code, not content. * documentation is small, so no -docs subpackage is necessary. (The docs are several times larger than the single executable, but the whole package is still under a megabyte. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review