https://bugzilla.redhat.com/show_bug.cgi?id=1884085 --- Comment #4 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> --- Hello Thanks for your review. > Issues > ====== > - The source RPM name should have "python-" prefixed to it, regardless of how > the prewikka package is named. See the Naming Guidelines: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_python_source_package_naming > However, since this is a SHOULD rather than a MUST, I will not block the > review on this point. OK, thanks, I think this is the best > > - I cannot verify that the license tag is correct. Unlike you, I don't know > the developers. Please ask them to put the license in writing somewhere, > even if it is in an email to you (which you would then includes as a source > file). Please also point out to them that term 1 of the GPL version 2 > requires us to pass on the copy of the GPL we received from them ... only > they didn't give us one: > > https://www.gnu.org/licenses/old-licenses/gpl-2.0.html > > At the very least, they should set the License field in PKG-INFO. Note that > it is not enough for them to simply add a file containing the license text > to the package. See the comment in the "GPL+" entry in this table: > > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses I may wrong explain myself. I'm in the developer team :). Nonetheless, the wiki has been updated : https://www.prelude-siem.org/projects/prelude/wiki/SourceOrganization , now it is clear that prewikka-updatedb is GPL v2. In the next release, we will add COPYING file and update the PKG-INFO. What is your advice to include this into the package ? > > - Remove line 11 of the spec file: > > Requires: python3-%{name} >= %{version} > > That accomplishes nothing, since there is no binary RPM for the main package, > so the dependency doesn't appear anywhere. > > - Remove line 18 of the spec file: > > Requires: %{name} = %{version}-%{release} > > Since the package also Provides that name, this is a self-dependency, which > accomplishes nothing useful. Done. See: New Spec URL: https://fedorapeople.org/~totol/prewikka-updatedb.spec New SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1810/53611810/prewikka-updatedb-5.2.0-1.fc34.src.rpm Thanks Regards -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
