https://bugzilla.redhat.com/show_bug.cgi?id=1892101 --- Comment #8 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to Neal Gompa from comment #7) > (In reply to Michel Alexandre Salim from comment #6) > > (In reply to Neal Gompa from comment #5) > > > Why are you doing "v%{version}.tar.gz#/%{name}-%{version}.tar.gz" instead of > > > "v%{version}/%{name}-%{version}.tar.gz"? > > > > It's to rename the source file when downloading. upstream's name is just > > v%{version}.tar.gz which is not descriptive. everything after the hash > > basically lets you give the local file a different name > > The URL structure I suggest matches how GitHub actually returns it when you > do wget with --content-disposition. It works perfectly with rpmdev-spectool. > Give it a shot and try for yourself. :) fails for me: $ spectool -gf fbthrift.spec Downloading: https://github.com/facebook/fbthrift/archive/v2020.10.26.00.tar.gz/fbthrift-2020.10.26.00.tar.gz Download failed: 404 Client Error: Not Found for url: https://codeload.github.com/facebook/fbthrift/tar.gz/v2020.10.26.00.tar.gz/fbthrift-2020.10.26.00 - 0.0 B Elapsed Time: -1 day, 17:00:01 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
