Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: poker3d - Three dimensional multi-user online poker game Alias: poker3d https://bugzilla.redhat.com/show_bug.cgi?id=355971 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-11-06 15:42 EST ------- I'll review this. Here are some MUST Fix and Should Fix from a first semi-thorough look: Must Fix: --------- * Source0 URL is invalid * icon cache scriptlets to not match the scriplets page on the wiki (the user will see an error printed when gtk-update-icon-cache isn't installed Should Fix: ----------- * Since the libraries are private, wouldn't it be a better idea to use a wrapper script which sets LD_LIBRARY_PATH, rather then adding the used dir to ld.so.conf.d, because that way they will still be in the global namespace, and there is little use in putting them in their own dir. * according to upstreams website 1.1.37 is out -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review