https://bugzilla.redhat.com/show_bug.cgi?id=1886464 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking a rough first look at this, there are some things that definitely need to be addressed: 1) Requires: rpm-libs This needs to be moved into the package that actually contains the binary (from line 22 to 31). 2) Cargo.toml specifies that this crate ships a shared library for use from C. But the dylib is not built, and the header file is not installed. Is this intentional? 3) Cargo.toml specifies license = "LGPL-2.1-or-later", but the crate contains both GPLv3+ and LGPLv2+ license texts. Which license applies to what? Looking at the license headers, it seems like the "blsctl" binary is GPLv3+ and the crate library component is LGPLv2+. The License tags in the .spec file need to reflect that. Assuming my assessment is correct, you'll need to add a "License: GPLv3+" tag to the binary package (line 32). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
