https://bugzilla.redhat.com/show_bug.cgi?id=1885430 --- Comment #8 from giovanni.cabiddu@xxxxxxxxx --- I uploaded a new version of the SPEC and the RPM: Spec URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib.spec SRPM URL: https://raw.githubusercontent.com/intel/qatlib/v20_08/rpm/qatlib-20.08.0-1.fc32.src.rpm > If this package is going to bundle openssl (even if only partially), there are two MUST requirements [0]. > > 1. Add the line `Provides: bundled(openssl) = <version>`. Based on [0] I added `Provides: bundled(libcrypto) = 1.1.1c`. If `openssl` is preferred I can change it. > 2. Open an issue upstream to request it be possible to build against the system openssl, and add a link to that issue as a comment in the spec file. Done. Opened a ticket [1] and added a comment before the line `Provides:`. A note on this. The reason why qatlib includes an implementation of MD5, SHA and AES [2] is to avoid a potential circular dependency when QAT OpenSSL Engine [3] is in the system. We are looking at a ways to remove the bundled libcrypto in qatlib and this change might be part of the next release. > On a related note, running rpmlint on the installed package generates the following warnings. > > qatlib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libqat.so.0.20.08.0 /lib64/libcrypto.so.1.1 > qatlib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libusdm.so.0.20.08.0 /lib64/libcrypto.so.1.1 > > The wiki has some notes on how to resolve this [1]. Done. Regarding the license on the spec file, I checked internally. We can change the license from BSD to MIT however we cannot remove the header on the file. One question regarding the Arch. Qatlib was tested and validated only on x86_64 platforms. Should we add `ExclusiveArch: x86_64` as described in [4] or mention explicitly the architectures where the build does not work as described in [5]? [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling [1] https://github.com/intel/qatlib/issues/2 [2] https://github.com/intel/qatlib/tree/main/quickassist/utilities/osal/src/linux/user_space/openssl [3] https://github.com/intel/QAT_Engine [4] https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch [5] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
