https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #22 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to Davide Cavalca from comment #20) > (In reply to Antonio T. sagitter from comment #18) > > folly.x86_64: W: no-documentation > > folly-static.x86_64: W: no-documentation > > FYI we do have documentation (under folly/docs, see > https://github.com/facebook/folly/tree/ > 2fa292ded20bb83383c010974bb7796b2832a84d/folly/docs). We should add a BR on > pandoc and build and ship this (possibly in its own subpackage). I missed this from our discussion, thanks for the reminder (In reply to Antonio T. sagitter from comment #21) > > - No tests ran > > Make '%check' section conditional, please. > Good point. It was not failing anyway but a bit misleading and a waste of time to invoke %ctest when we know it will be a no-op > The review is complete. Package approved. Thanks so much! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
