https://bugzilla.redhat.com/show_bug.cgi?id=1887621 --- Comment #12 from Davide Cavalca <dcavalca@xxxxxx> --- (In reply to Neal Gompa from comment #11) > Main value of using PROPERTIES VERSION over OUTPUT_NAME is that CMake > handles structuring the filename correctly for the target OS for you (e.g. > <name>-<version>.dll for Windows and Midipix, lib<name>.<version>.dylib for > macOS, lib<name>.so.<version> for Linux/BSD, etc.). My understanding is that > OUTPUT_NAME turns all that logic off. Thanks, fixed this upstream in https://github.com/facebook/folly/commit/f817aff73bea2ce956ec2212c34d12cd206f31cf (In reply to Michel Alexandre Salim from comment #8) > I needed to add -fPIC, which is not in the default CXXFLAGS This is also fixed upstream in https://github.com/facebook/folly/commit/3b1bdb98c3e2ca1e18db4a74c2674f22a7d05b48 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
