https://bugzilla.redhat.com/show_bug.cgi?id=1885495 --- Comment #10 from Dinesh <dineshx.balakrishnan@xxxxxxxxx> --- (In reply to Carl George 🤠 from comment #5) > It's already been pointed out that the review tool won't work correctly > until: > > - it can download the raw text of the spec file > - it can build the package, which requires qatlib to be available > > You also haven't posted a link to the SRPM. Please follow the template. > > Spec URL: <spec info here> > SRPM URL: <srpm info here> > Description: <description here> > Fedora Account System Username: > > Also, can you clarify if the intent of the spec file license comment is to > override the default MIT license specified by the FPCA? I still recommend > removing that if you're willing to. It's completely acceptable for the spec > file to be under the default MIT license, and the software it is building be > under a different license. Spec URL: https://download.copr.fedorainfracloud.org/results/dineshbx/qatengine/srpm-builds/01715062/qatengine.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dineshbx/qatengine/srpm-builds/01715062/qatengine-0.6.1-1.fc32.src.rpm Description: This package contains OpenSSL Engine providing cryptographic hardware acceleration using Intel(R) QuickAssist Technology which provides optimized implementations of cryptography on Intel(R) platforms. Fedora Account System Username: dineshbx Also, we will remove the license information from the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
