https://bugzilla.redhat.com/show_bug.cgi?id=1889705 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > BuildRequires > FIX: Please add following build-requires: > perl-interpreter - perl-Test-Net-LDAP.spec:36 > make - perl-Test-Net-LDAP.spec:37 > coreutils - perl-Test-Net-LDAP.spec:45 > FIX: Add a build-require 'findutils' used in spec file. +BuildRequires: coreutils +BuildRequires: findutils +BuildRequires: make BuildRequires: perl-generators +BuildRequires: perl-interpreter Ok. > If you want to add it to EPEL 7, please do: > TODO: Replace PERL_INSTALL_ROOT with more common DESTDIR. -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT ok. > TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null > \;". > It's not needed. find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; -find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; Ok. > FIX: Add following binary requires: > perl(Net::LDAP::Bind) - lib/Test/Net/LDAP/Mock/Data.pm:181 > perl(Net::LDAP::RootDSE) - lib/Test/Net/LDAP/Mock/Data.pm:92 > perl(Net::LDAP::Search) - lib/Test/Net/LDAP/Mock/Data.pm:257 Not solve, please add them. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
