https://bugzilla.redhat.com/show_bug.cgi?id=1889387 --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I have one question: %if !%{build_terminfo} tic -xe alacritty,alacritty-direct %{crate}-%{version_no_tilde}/extra/alacritty.info \ -o %{buildroot}%{_datadir}/terminfo %endif This means that "if not build terminfo then build terminfo" ... So I guess your 0 / 1 definitions in the .spec preamble are the wrong way round. I think things should be: %if 0%{?fedora} >= 33 %global build_terminfo 0 %else %global build_terminfo 1 %endif and %if !%{build_terminfo} BuildRequires: ncurses >= 6.2 Recommends: ncurses-base >= 6.2 %endif and %if %{build_terminfo} %{_datadir}/terminfo/a/alacritty* %endif and %if %{build_terminfo} tic -xe alacritty,alacritty-direct %{crate}-%{version_no_tilde}/extra/alacritty.info \ -o %{buildroot}%{_datadir}/terminfo %endif respectively, to make sense with the name of the macro. The way you did it now, the macro should probably be "do_not_build_terminfo" :) You can fix that at import. I'm running fedora-review again now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
