https://bugzilla.redhat.com/show_bug.cgi?id=1889362 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: 1) You should use %{version} in the Source URL instead of hardcocded values. 2) You could use %{url} in the Source URL to make it shorter (but you don't have to). 3) The description of python3-fastjsonschema could be longer. What about reusing the main description? 4) I find the macro %{srcname} a tad confusing in this context, since the source repo is called python-fastjsonschema. Is strongly suggest to either rename the macro to %{pypi_name} or to replace the macro with the value. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
