https://bugzilla.redhat.com/show_bug.cgi?id=1889073 --- Comment #1 from Andy Mender <andymenderunix@xxxxxxxxx> --- > URL: http://foo2zjs.rkkda.com/ > Source0: %{name}-%{foo2zjs_ver}-clean.tar.xz Source0 should point to a URL where the tarball can be downloaded from. Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/foo2zjs See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GPL (v2 or later)", "GPL (v2 or later) (with incorrect FSF address)", "GNU General Public License", "GPL (v2 or later)", "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "Expat License". 400 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/review- foo2zjs/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/foo2qpdl, /usr/share/foo2qpdl/crd Review: Make sure the foo2qpdl subpackage owns its directories properly. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/foomatic, /usr/share/foomatic/db/source/printer, /usr/share/foo2qpdl, /usr/share/cups/model, /usr/share/foo2qpdl/crd, /usr/share/foomatic/db/source, /usr/share/foomatic/db/source/opt, /usr/share/cups, /usr/share/foomatic/db/source/driver, /usr/share/foomatic/db Review: The foo2qpdl subpackage should own the following: /usr/share/foo2qpdl /usr/share/foo2qpdl/crd Add Requires: cups for the following: /usr/share/cups/model /usr/share/cups Add Requires: foomatic-db for the following: /usr/share/foomatic/db/source/printer /usr/share/foomatic/db/source /usr/share/foomatic/db/source/opt /usr/share/foomatic/db/source/driver /usr/share/foomatic/db Add Requires: foomatic for the following: /usr/share/foomatic [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 921600 bytes in 20 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Scriptlets must be sane, if used. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _lto_cflags %{nil}, %define foo2zjs_ver 20201003 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 5775360 bytes in /usr/share Review: Might require an extra -data subpackage. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 2.6 starting (python version = 3.8.6)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.6 INFO: Mock Version: 2.6 Finish: chroot init INFO: installing package(s): /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2slx-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2ddst-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hiperc-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2lava-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hp-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2oak-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hbpl-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2xqx-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-debuginfo-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2qpdl-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-debugsource-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-0.20201003-14.fc34.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2slx-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2ddst-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hiperc-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2lava-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hp-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2oak-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2hbpl-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2xqx-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-debuginfo-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2qpdl-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-debugsource-0.20201003-14.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/foo2zjs/copr-build-1710872/foo2zjs-0.20201003-14.fc34.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: foo2zjs-0.20201003-14.fc34.x86_64.rpm foo2hp-0.20201003-14.fc34.x86_64.rpm foo2xqx-0.20201003-14.fc34.x86_64.rpm foo2lava-0.20201003-14.fc34.x86_64.rpm foo2qpdl-0.20201003-14.fc34.x86_64.rpm foo2slx-0.20201003-14.fc34.x86_64.rpm foo2hiperc-0.20201003-14.fc34.x86_64.rpm foo2oak-0.20201003-14.fc34.x86_64.rpm foo2hbpl-0.20201003-14.fc34.x86_64.rpm foo2ddst-0.20201003-14.fc34.x86_64.rpm foo2zjs-debuginfo-0.20201003-14.fc34.x86_64.rpm foo2zjs-debugsource-0.20201003-14.fc34.x86_64.rpm foo2zjs-0.20201003-14.fc34.src.rpm foo2zjs.x86_64: W: spelling-error %description -l en_US magicolor -> magi color, magi-color, magical foo2zjs.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2hp.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2xqx.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2lava.x86_64: W: spelling-error %description -l en_US magicolor -> magi color, magi-color, magical foo2lava.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2lava.x86_64: W: no-manual-page-for-binary command2foo2lava-pjl foo2qpdl.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2slx.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2oak.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2hbpl.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2ddst.x86_64: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2zjs.src: W: spelling-error %description -l en_US magicolor -> magi color, magi-color, magical foo2zjs.src: W: spelling-error %description -l en_US winprinters -> win printers, win-printers, teleprinters foo2zjs.src: W: invalid-url Source0: foo2zjs-20201003-clean.tar.xz 13 packages and 0 specfiles checked; 0 errors, 15 warnings. Requires -------- foo2zjs (rpmlib, GLIBC filtered): /usr/bin/bash /usr/bin/sh argyllcms(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2hp (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2xqx (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2lava (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libcups.so.2()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2qpdl (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2slx (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2hiperc (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2oak (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2hbpl (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2ddst (rpmlib, GLIBC filtered): /usr/bin/sh foo2zjs(x86-64) lcms(x86-64) libc.so.6()(64bit) libjbig.so.2.1()(64bit) rtld(GNU_HASH) foo2zjs-debuginfo (rpmlib, GLIBC filtered): foo2zjs-debugsource (rpmlib, GLIBC filtered): Provides -------- foo2zjs: foo2zjs foo2zjs(x86-64) postscriptdriver(hewlett-packard;hp_laserjet_1000;) postscriptdriver(hewlett-packard;hp_laserjet_1005_series;) postscriptdriver(hewlett-packard;hp_laserjet_1018;) postscriptdriver(hewlett-packard;hp_laserjet_1020;) postscriptdriver(hewlett-packard;hp_laserjet_1022;) postscriptdriver(hewlett-packard;hp_laserjet_1022n;) postscriptdriver(hewlett-packard;hp_laserjet_1022nw;) postscriptdriver(konica_minolta;magicolor_2300_dl;) postscriptdriver(konica_minolta;magicolor_2430_dl;) postscriptdriver(minolta-qms;magicolor_2300_dl;) postscriptdriver(minolta-qms;magicolor_2430_dl;) foo2hp: foo2hp foo2hp(x86-64) postscriptdriver(hewlett-packard;hp_color_laserjet_1600;) postscriptdriver(hewlett-packard;hp_color_laserjet_2600n;) postscriptdriver(hewlett-packard;hp_color_laserjet_cp1215;) foo2xqx: foo2xqx foo2xqx(x86-64) postscriptdriver(hewlett-packard;hp_laserjet_cp1025nw;) postscriptdriver(hewlett-packard;hp_laserjet_m1005;) postscriptdriver(hewlett-packard;hp_laserjet_m1120;) postscriptdriver(hewlett-packard;hp_laserjet_m1132;) postscriptdriver(hewlett-packard;hp_laserjet_m1319;) postscriptdriver(hewlett-packard;hp_laserjet_p1005;) postscriptdriver(hewlett-packard;hp_laserjet_p1006;) postscriptdriver(hewlett-packard;hp_laserjet_p1007;) postscriptdriver(hewlett-packard;hp_laserjet_p1008;) postscriptdriver(hewlett-packard;hp_laserjet_p1505;) postscriptdriver(hewlett-packard;hp_laserjet_p2014;) postscriptdriver(hewlett-packard;hp_laserjet_p2035;) postscriptdriver(hewlett-packard;hp_laserjet_pro_p1566;) postscriptdriver(hewlett-packard;hp_laserjet_professional_m1212nf;) postscriptdriver(hewlett-packard;hp_laserjet_professional_m12a;) postscriptdriver(hewlett-packard;hp_laserjet_professional_m12w;) postscriptdriver(hewlett-packard;hp_laserjet_professional_p1102;) postscriptdriver(hewlett-packard;hp_laserjet_professional_p1102w;) postscriptdriver(hewlett-packard;hp_laserjet_professional_p1606dn;) foo2lava: foo2lava foo2lava(x86-64) postscriptdriver(konica_minolta;magicolor_2480_mf;) postscriptdriver(konica_minolta;magicolor_2490_mf;) postscriptdriver(konica_minolta;magicolor_4690mf;) postscriptdriver(konica_minolta;mc1600w;) postscriptdriver(konica_minolta;mc1680mf;) postscriptdriver(konica_minolta;mc1690mf;) postscriptdriver(konica_minolta;mc2530dl;) foo2qpdl: foo2qpdl foo2qpdl(x86-64) postscriptdriver(samsung;clp-310_series;) postscriptdriver(samsung;clp-320_series;) postscriptdriver(samsung;ml-1670_series;) postscriptdriver(xerox;phaser_6110;) foo2slx: foo2slx foo2slx(x86-64) foo2hiperc: foo2hiperc foo2hiperc(x86-64) postscriptdriver(oki_data_corp;c110;) foo2oak: foo2oak foo2oak(x86-64) postscriptdriver(hewlett-packard;hp_color_laserjet_1500;) foo2hbpl: foo2hbpl foo2hbpl(x86-64) postscriptdriver(fuji_xerox;docuprint_cm215;) postscriptdriver(xerox;workcentre_3045b;) foo2ddst: foo2ddst foo2ddst(x86-64) foo2zjs-debuginfo: debuginfo(build-id) foo2zjs-debuginfo foo2zjs-debuginfo(x86-64) foo2zjs-debugsource: foo2zjs-debugsource foo2zjs-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
