https://bugzilla.redhat.com/show_bug.cgi?id=1889104 --- Comment #3 from Lyes Saadi <fedora@xxxxxxx> --- All your issues were addressed (I also included the description in a `%global` instead of having it repeated twice). Spec URL: https://lyessaadi.fedorapeople.org/dialect/python-googletrans.spec SRPM URL: https://lyessaadi.fedorapeople.org/dialect/python-googletrans-3.0.0-2.fc33.src.rpm --- > > %{?python_disable_dependency_generator} > > > > %{?python_provide:%python_provide python3-%{pypi_name}} > > Please, switch to the %py_provides macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro I removed it entirely since the package will likely never be packaged for f32- because of #1887012. > > %files -n python3-%{pypi_name} > > %doc README.rst > > %{python3_sitelib}/%{pypi_name}* > > %{_bindir}/%{pypi_name} > > [...] > > Also, if this package is to be used by another package, it should provide egg info, by adding the following line at the end of the %files section: > %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/ This was already covered by the glob `%{python3_sitelib}/%{pypi_name}*` but I do think that this is a bad thing to do, so I removed it and replaced it by the more traditional way to do it. --- Sorry for all those quite silly mistakes, it's only my second time unretiring a package, and I'd thought that this package would've been in a better shape, so I haven't checked thoroughly for errors, which I should've. Anyway, thank you again for this quick and thorough review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
