[Bug 1880848] Review Request: golang-github-rickb777-date - A Go package for working with dates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1880848



--- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> ---
Spec URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01710314-golang-github-rickb777-date/golang-github-rickb777-date.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/cheeselee/deepin-packit-testing/fedora-rawhide-x86_64/01710314-golang-github-rickb777-date/golang-github-rickb777-date-1.14.2-1.fc34.src.rpm

Change:
- Update to 1.14.2

(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=53019328
> 
> It fails on i686 and armv7hl. Please, have a look at the errors.
Fixed in 1.14.2.

> 
> > Version:                1.14.0
> 
> Version 1.14.1 is already out, feel free to update:
> https://github.com/rickb777/date/releases/tag/v1.14.1
Updated to 1.14.2

> [ ]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
>      github-rickb777-date-devel
>      Review: Not sure about this. Golang packages are auto-generated
>      and the -devel package is not listed in the SPEC file.
Not needed theoretically. The golang guideline does not talk about this.

> Installation errors
> -------------------
> INFO: mock.py version 2.6 starting (python version = 3.8.5)...
> Start: init plugins
> INFO: selinux enabled
> Finish: init plugins
> INFO: Signal handler active
> Start: run
> Start: chroot init
> INFO: calling preinit hooks
> INFO: enabled root cache
> INFO: enabled package manager cache
> Start: cleaning package manager metadata
> Finish: cleaning package manager metadata
> INFO: enabled HW Info plugin
> Mock Version: 2.6
> INFO: Mock Version: 2.6
> Finish: chroot init
> INFO: installing package(s):
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-debuginfo-1.14.0-1.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-1.14.0-1.fc34.x86_64.rpm
> ERROR: Command failed: 
>  # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
> --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local
> --disableplugin=spacewalk install
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-debuginfo-1.14.0-1.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
> /home/amender/rpmbuild/SPECS/golang-github-rickb777-date/golang-github-
> rickb777-date-1.14.0-1.fc34.x86_64.rpm --setopt=tsflags=nocontexts
I tested in mock that the new packages are installable.

> 
> 
> 
> Rpmlint
> -------
> Checking: golang-github-rickb777-date-1.14.0-1.fc34.x86_64.rpm
>           golang-github-rickb777-date-devel-1.14.0-1.fc34.noarch.rpm
>           golang-github-rickb777-date-1.14.0-1.fc34.src.rpm
> golang-github-rickb777-date.x86_64: E:
> shared-lib-without-dependency-information /usr/bin/datetool
> Review: Could you have a look at this?
The tool is simple and does not call function in external library. As
'--as-needed' is enabled in linking so the executable finally has no
needed library.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux