https://bugzilla.redhat.com/show_bug.cgi?id=1884085 --- Comment #2 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> --- Hello Thanks for your review New Spec URL: https://fedorapeople.org/~totol/prewikka-updatedb.spec New SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1810/53611810/prewikka-updatedb-5.2.0-1.fc34.src.rpm Please make a new review. Thanks ! > >Here are some preliminary questions and observations. > >- The name of the package/spec file should be python-prewikka-updatedb; see > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_python_source_package_naming The prewikka package is like this. I prefer to keep prewikka-updatedb. See https://src.fedoraproject.org/rpms/prewikka > >- Why does the spec file contain this: > > # Since mass rebuild, debugpackage wont works for prelude-correlator > %define debug_package %{nil} > > instead of this? > > BuildArch: noarch Done > >- Where did you get the license tag? The only mention of a license that I see > is in prewikkaupdatedb/filter/update310.py, where the Converter class is > declared to be in the public domain. PKG-INFO says that the license is > UNKNOWN. I know the developers and they told me it is like Prewikka. > >- The text at the top of /usr/lib/rpm/macros.d/macros.python-srpm indicates > that %{python3} should be used instead of %{__python3} when invoking the > interpreter in a spec file. On the other hand, is there a reason why > %install doesn't just invoke %py3_install? Done > >- Isn't line 22 of the spec file: > > Requires: python3-prewikka >= %{version} > > backwards? That is, doesn't prewikka require prewikka-updatedb, not the > other way around? Prewikka can works without prewikka-updatedb but installing prewikka-updatedb without prewikka is a nonsense. So it is OK I think > >- Line 23 of the spec file: > > %{?python_provide:%python_provide python3-%{name}} > > is no longer needed in Fedora 33 and later. If you do not plan to build for > EPEL or Fedora <= 32, then you can omit this line. Done > >- The empty %files on line 37 of the spec file is wrong. It leads to the > creation of an empty and unnecessary prewikka-updatedb binary package. Once > that is removed, the Requires on lines 11 and 21 are also not needed. If you > want the python3 package to be installable via the name prewikka-updatedb, > then add "Provides: prewikka-updatedb = %{version}-%{release}" to the python3 > subpackage. Done > >- Line 40 of the spec file has an extraneous /: > > %{python3_sitelib}//prewikkaupdatedb/ Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
