Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: wqy-zenhei-fonts - A Hei Ti style Chinese outline font https://bugzilla.redhat.com/show_bug.cgi?id=361121 petersen@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag|fedora-review? |fedora-review+ ------- Additional Comments From petersen@xxxxxxxxxx 2007-11-06 02:51 EST ------- Thanks. Here is the review: Good: + rpmlint clean, except waivable wqy-zenhei-fonts.noarch: W: symlink-should-be-relative /etc/X11/fontpath.d/wqy-zenhei-fonts /usr/share/fonts/wqy-zenhei + package is named after upstream wqy-zenhei + meets packaging guidelines + license is GPL2 with font embedding exception + source matches upstream tarball 1b79021d813cc22e1be3a117533d8145 wqy-zenhei-0.2.16-CVS20071031.tar.gz + noarch package builds correctly + buildreq is listed + filelist is correct + good macro usage + content is a free truetype font Needs attention - according to http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837 the release field should be 0.1.20071031cvs to make it clear that it is a snapshot release. I tested the package and it seems to work ok. I note that it seems to override cjkunifonts. Except maybe the release field as noted above, all MUST items are satisfied. Package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review