Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-hpricot - A Fast, Enjoyable HTML Parser for Ruby https://bugzilla.redhat.com/show_bug.cgi?id=364211 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-11-06 02:41 EST ------- (In reply to comment #1) > I had to reacquaint myself with the Ruby guidelines.... > > One question: This is also available as a gem. If something ends up needing the > gem, you'll have to abandon this package and submit rubygem-hpricot for review. > So it's worth asking: are you sure that nothing will want this as a gem, and if > not then wouldn't it be easier to do it all at once? Well, in general non-gem ruby module and gem ruby module are the same in function. So I think no one would want gem hpricot if we provide non-gem hpricot in rpm. > > Regardless, I'll go ahead and review this; a gem package shouldn't be much > different. > > I note there's an hpricot-0.6 tarball on the upstream web site, but I don't know > if you'd want to use it. Thank you for information. I will check it later. > > This package looks fine, save for one thing. The guidelines spefically state > that you need RuildRequires: ruby. Currently ruby is only being brought in for > this build because rake has a dependency on /usr/bin/ruby. I honestly don't > know if this is a real issue. Yes, as rake needs /usr/bin/ruby, I removed the explicit BuildRequires. (In reply to comment #2) > Chatted with the primary author of the ruby guidelines and he agreed that this > usage is OK. We will get that bit of the guidelines changed. > > APPROVED Thank you for your review! ---------------------------------------------------------------------- New Package CVS Request ======================= Package Name: ruby-hpricot Short Description: A Fast, Enjoyable HTML Parser for Ruby Owners: mtasaka Branches: FC-6 F-7 F-8 InitialCC: (nobody) Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review