https://bugzilla.redhat.com/show_bug.cgi?id=1884110 Andy Mender <andymenderunix@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> --- I see the LICENSE file was already merged to master: https://raw.githubusercontent.com/zakariakov/booksorg/master/LICENSE Hopefully, it will be added to the next release. At the beginning of the %files block please add something like this: # License file requested: https://github.com/zakariakov/booksorg/pull/8 # %license LICENSE The Requires for hicolor-icon-theme is still missing so please add it as well: Requires: qt5-qtbase Requires: hicolor-icon-theme You can do it on package import. The rest looks okay. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
