[Bug 1883732] Review Request: rubygem-sassc-rails - Integrate SassC-Ruby into Rails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1883732



--- Comment #3 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Weird RexExp
  - The 'g' in the following RegExp is probably not needed, since you are
matching single line anyway:

~~~
sed -i -e '/require .pry./ s/^/#/g' test/test_helper.rb
~~~

* Test suite
  - It seems you got completely drown. If you started with the
rubygem-sass-rails, it would be easier. This is where I got:

~~~
... snip ...

BuildRequires: rubygem(bundler)
BuildRequires: rubygem(mocha)
BuildRequires: rubygem(railties)
BuildRequires: rubygem(sassc)
BuildRequires: rubygem(sprockets-rails)
BuildRequires: rubygem(tilt)

... snip ...

%check
pushd .%{gem_instdir}
# Copy in .gemspec and use the sass-rails sources
cp %{buildroot}%{gem_spec} sassc-rails.gemspec

# Avoid unnecessary dependency
sed -i -e '/require .pry./ s/^/#/g' test/test_helper.rb
sed -i -e '/dependency.*pry./ s/^/#/' sassc-rails.gemspec

sed -i -e '/dependency.*rake./ s/^/#/' sassc-rails.gemspec

ruby -e 'Dir.glob "./test/**/*.rb", &method(:require)'
popd

... snip ...
~~~

  - BTW some of the failures could be, because you have required
`rubygem(sass)` instead of `rubygem(sassc)` (note the 'c' difference).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux