[Bug 1887187] Review Request: perl-Test2-Tools-PerlCritic - Testing tools to enforce Perl::Critic policies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1887187

Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
> FIX: Please add build-requires 
>      perl-generators - package does not list all Perl run-time dependencies
> and it relies on the generators
>      perl-interpreter - perl-Test2-Tools-PerlCritic.spec:48
>      make - perl-Test2-Tools-PerlCritic.spec:49 - The macro is provided by
> rpm that does not depend on make
> TODO: Please use 'perl(:VERSION) >= 5.20' instead of 'perl >= 0:5.020'. 
>       The package 'perl' install interpreter and all core modules. 
>       It is not needed.

-BuildRequires:  perl >= 0:5.020
 # build requirements
+BuildRequires:  make
+BuildRequires:  perl-generators
+BuildRequires:  perl-interpreter >= 5.20

Ok

Resolution:
Approved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux