https://bugzilla.redhat.com/show_bug.cgi?id=1887187 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Please add build-requires perl-generators - package does not list all Perl run-time dependencies and it relies on the generators perl-interpreter - perl-Test2-Tools-PerlCritic.spec:48 make - perl-Test2-Tools-PerlCritic.spec:49 - The macro is provided by rpm that does not depend on make TODO: Please use 'perl(:VERSION) >= 5.20' instead of 'perl >= 0:5.020'. The package 'perl' install interpreter and all core modules. It is not needed. $ rpm -qp --requires perl-Test2-Tools-PerlCritic-0.03-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(:MODULE_COMPAT_5.32.0) FIX: Build-require 'perl-generators' $ rpm -qp --provides perl-Test2-Tools-PerlCritic-0.03-1.fc34.noarch.rpm | sort | uniq -c 1 perl-Test2-Tools-PerlCritic = 0.03-1.fc34 FIX: Build-require 'perl-generators' $ rpmlint ./perl-Test2-Tools-PerlCritic* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: NOT approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
