Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: readline https://bugzilla.redhat.com/show_bug.cgi?id=226361 ------- Additional Comments From mlichvar@xxxxxxxxxx 2007-11-05 13:34 EST ------- (In reply to comment #2) > 1)rpmlint complained on RPM > readline-devel.i386: W: file-not-utf8 /usr/share/doc/readline-devel-5.2/rl-fgets.c > The character encoding of this file is not UTF-8. Consider converting it > in the specfile for example using iconv(1). Ok. > 2) defattr usage should be defattr(-,root,root,-) Ok. Fixed with 1) in readline-5.2-8.fc9. > 3) Good to follow Texinfo scriptlet given at > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db With more commands in the script it's IMHO nicer to put : at the end of the script. It's mentioned in the ScriptletSnippets page. > 4) Do we need static package here? lvm2 buildrequires readline-static. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review