https://bugzilla.redhat.com/show_bug.cgi?id=1882547 --- Comment #3 from Artem <ego.cordatus@xxxxxxxxx> --- (In reply to Petr Pisar from comment #2) > TODO: Source0 URL differs from the one listed on the releases page > <https://github.com/mtrojnar/osslsigncode/archive/2.0.tar.gz>. I'd prefer to > have them the same. Disagree here, this is normal to use GitHub API for downloading release tarballs like that in Fedora https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags If all sources will named like that ("2.0.tar.gz") there will be a real mess and file naming conflicts in rpmbuild/SOURCES or just hard to find necessary source if there are many. > TODO: Perform upstream tests. You can install mingw32-gcc and > /usr/bin/keytool, then comile a trivial C program with > i686-w64-mingw32-gcc to produce a PE executable, then rename it to > tests/putty.exe, slightly patch tests/testsign.sh > not to delete putty.exe, and finaly execute tests/testsign.sh. I've added tests now and they are passed. Network not required during tests. But you need to review this and i'm not sure how you feel about it. :) Anyway we can improve this in future. The rest is fixed look like. Thanks for great review. --- https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-33-x86_64/01703705-osslsigncode/osslsigncode.spec https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-33-x86_64/01703705-osslsigncode/osslsigncode-2.0-3.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
