[Bug 1887091] Review Request: jack-mixer - JACK Audio Mixer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1887091



--- Comment #1 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> ---
1: Remove

BuildRequires:  autoconf

$ rpm -q --requires automake |grep auto
autoconf >= 2.65


2: You are running configure twice, change

./autogen.sh

to

NOCONFIGURE=1 ./autogen.sh

3: You haven't validated the desktop file

%{_datadir}/applications/jack_mixer.desktop

See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

4: Why two %doc?, change

%doc README.md
%doc NEWS

to

%doc NEWS README.md


5: Remove

Requires:       jack-audio-connection-kit

and

Requires:       python3


Autorequires takes care of them


rpm -qp --requires
/home/leigh/rpmbuild/RPMS/x86_64/jack-mixer-13-1.fc33.x86_64.rpm |grep
libjack.so.0
libjack.so.0()(64bit)

and

$ rpm -qp --requires
/home/leigh/rpmbuild/RPMS/x86_64/jack-mixer-13-1.fc33.x86_64.rpm |grep
/usr/bin/python3
/usr/bin/python3


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux