Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: docbook-slides https://bugzilla.redhat.com/show_bug.cgi?id=225702 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovasik@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-11-05 11:26 EST ------- 1) rpmlint gave me docbook-slides.noarch: W: dangerous-command-in-%post chmod docbook-slides.noarch: W: dangerous-command-in-%postun rm I guess this is needed for this package. 2)change buildroot to standard acceptable one. http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 3)Preserve timestamps http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d175c4aec8c12868dffb5ab 4) defattr should be %defattr (-,root,root,-) I think this should be used. 5) Use macros instead of hard-coded directory names http://fedoraproject.org/wiki/Packaging/Guidelines#head-255d52ff18f82fa184a32946b82ed81e4fd8885a -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review