https://bugzilla.redhat.com/show_bug.cgi?id=1882527 --- Comment #11 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the review! (In reply to Jerry James from comment #10) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - The SHOULD section warns that this package contains fonts. That is due to > sphinx-rtd-theme copying font files into the documentation directories. In > my packages, I have been requiring the relevant fonts: > > Requires: fontawesome-fonts-web > Requires: font(fontawesome) > Requires: font(lato) > Requires: font(robotoslab) > > then going through contortions to replace the font files with symlinks to > the fonts in those packages. See python-cvxopt for an example. It is ugly > and horrible and possibly not worth the effort. I'll let you judge that. > > - Regarding the rpmlint rpm-buildroot-usage warning, on line 74 of the spec > file, PYTHONPATH is set to point into %{buildroot}. Is that right? This > is %build, so %install hasn't happened yet. > Upstream provides docs on rtd, so I've disabled the doc generation. It isn't worth the effort of unbundling the fonts etc. I also fixed the second issue (but since the docs aren't being generated, that line isn't used anyway). * Fri Oct 09 2020 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.4.6-2 - Do not include generated docs: bundle lots of fonts - Correct doc generation command Updated spec/srpm: Spec: https://ankursinha.fedorapeople.org/python-sklearn-nature-inspired-algorithms/python-sklearn-nature-inspired-algorithms.spec SRPM: https://ankursinha.fedorapeople.org/python-sklearn-nature-inspired-algorithms/python-sklearn-nature-inspired-algorithms-0.4.6-2.fc33.src.rpm Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
