[Bug 1886621] Review Request: php-pecl-datadog_trace - APM and distributed tracing for PHP to Datadog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1886621

Daniel Axelrod <fedora@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(ngompa13@xxxxxxxx
                   |                            |m)



--- Comment #7 from Daniel Axelrod <fedora@xxxxxxxxxxxxx> ---
Thank you for your review, approval, and sponsorship, @ngompa13@xxxxxxxxx !

>> - If your application is a C or C++ application you must list a
>>  BuildRequires against gcc, gcc-c++ or clang.
>>  Note: No gcc, gcc-c++ or clang found in BuildRequires
>>  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
>
> This is relatively minor, you can add this on import.

The package already BuildRequires php-devel, which Requires gcc. This should be
sufficient to ensure that gcc is available when building
php-pecl-datadog_trace. By my interpretation, this means that the package as-is
already satisfies this packaging guideline and shouldn't require modification.

However, if you believe the packaging guideline requires an explicit first
level BuildRequires on gcc, just let me know, and I'm happy to do that.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux