[Bug 1881183] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1881183

Link Dupont <link@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #12 from Link Dupont <link@xxxxxxxxxxx> ---
The license check found a few additional licenses that are included in the
source distribution. Let's add those to the License field:

- Boost Software License 1.0
- zlib/libpng license
- BSD 3-clause "New" or "Revised" License

Should the freeorion-data subpackage Require: the %fonts rather than the
freeorion package, since the -data subpackage is the one containing the
symlinks?

Full Package Review follows:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/freeorion
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[*]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License Creative Commons Attribution-ShareAlike 3.0 Unported License",
     "GNU Lesser General Public License (v2.1 or later)", "GPL (v2 or
     later)", "BSD 3-clause "New" or "Revised" License", "GPL (v2) GNU
     Lesser General Public License", "zlib/libpng license GNU Lesser
     General Public License (v2.1 or later)", "Boost Software License 1.0",
     "*No copyright* Public domain", "zlib/libpng license", "*No copyright*
     zlib/libpng license". 3555 files have unknown license. Detailed output
     of licensecheck in /home/link/1881183-freeorion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 184320 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[*]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     freeorion-data
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: freeorion-0.4.10-4.fc34.x86_64.rpm
          freeorion-data-0.4.10-4.fc34.noarch.rpm
          freeorion-debuginfo-0.4.10-4.fc34.x86_64.rpm
          freeorion-debugsource-0.4.10-4.fc34.x86_64.rpm
          freeorion-0.4.10-4.fc34.src.rpm
freeorion.x86_64: W: no-manual-page-for-binary freeorion
freeorion.x86_64: W: no-manual-page-for-binary freeorionca
freeorion.x86_64: W: no-manual-page-for-binary freeoriond
freeorion-data.noarch: W: no-documentation
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/DejaVuSans-Bold.ttf
/usr/share/fonts/dejavu-sans-fonts/DejaVuSans-Bold.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/DejaVuSans.ttf
/usr/share/fonts/dejavu-sans-fonts/DejaVuSans.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/Roboto-Bold.ttf
/usr/share/fonts/google-roboto/Roboto-Bold.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/Roboto-Regular.ttf
/usr/share/fonts/google-roboto/Roboto-Regular.ttf
freeorion-data.noarch: E: zero-length
/usr/share/freeorion/default/python/AI/DynamicResearchAI.py
freeorion-data.noarch: E: non-executable-script
/usr/share/freeorion/default/python/common/charting/charts.py 644
/usr/bin/python2 
freeorion.src:46: W: mixed-use-of-spaces-and-tabs (spaces: line 46, tab: line
1)
5 packages and 0 specfiles checked; 2 errors, 9 warnings.




Rpmlint (debuginfo)
-------------------
Checking: freeorion-debuginfo-0.4.10-4.fc34.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
freeorion-debugsource.x86_64: W: invalid-url URL: http://freeorion.org <urlopen
error [Errno -3] Temporary failure in name resolution>
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
freeorion-data.noarch: W: invalid-url URL: http://freeorion.org <urlopen error
[Errno -3] Temporary failure in name resolution>
freeorion-data.noarch: W: no-documentation
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/DejaVuSans-Bold.ttf
/usr/share/fonts/dejavu-sans-fonts/DejaVuSans-Bold.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/DejaVuSans.ttf
/usr/share/fonts/dejavu-sans-fonts/DejaVuSans.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/Roboto-Bold.ttf
/usr/share/fonts/google-roboto/Roboto-Bold.ttf
freeorion-data.noarch: W: dangling-symlink
/usr/share/freeorion/default/data/fonts/Roboto-Regular.ttf
/usr/share/fonts/google-roboto/Roboto-Regular.ttf
freeorion-data.noarch: E: zero-length
/usr/share/freeorion/default/python/AI/DynamicResearchAI.py
freeorion-data.noarch: E: non-executable-script
/usr/share/freeorion/default/python/common/charting/charts.py 644
/usr/bin/python2 
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
freeorion.x86_64: W: invalid-url URL: http://freeorion.org <urlopen error
[Errno -3] Temporary failure in name resolution>
freeorion.x86_64: W: no-manual-page-for-binary freeorion
freeorion.x86_64: W: no-manual-page-for-binary freeorionca
freeorion.x86_64: W: no-manual-page-for-binary freeoriond
freeorion.x86_64: E: invalid-appdata-file
/usr/share/appdata/freeorion.appdata.xml
warning: Found bdb Packages database while attempting sqlite backend: using bdb
backend.
freeorion-debuginfo.x86_64: W: invalid-url URL: http://freeorion.org <urlopen
error [Errno -3] Temporary failure in name resolution>
4 packages and 0 specfiles checked; 3 errors, 12 warnings.



Unversioned so-files
--------------------
freeorion: /usr/lib64/freeorion/libGiGi.so
freeorion: /usr/lib64/freeorion/libfreeorioncommon.so
freeorion: /usr/lib64/freeorion/libfreeorionparse.so

Source checksums
----------------
https://github.com/freeorion/freeorion/releases/download/v0.4.10/FreeOrion_v0.4.10_2020-07-10.f3d403e_Source.tar.gz
:
  CHECKSUM(SHA256) this package     :
e72ab42cba1ee8842507340931ef389e64011e040a4adc74add5f4997bbcba8b
  CHECKSUM(SHA256) upstream package :
e72ab42cba1ee8842507340931ef389e64011e040a4adc74add5f4997bbcba8b


Requires
--------
freeorion (rpmlib, GLIBC filtered):
    font(dejavusans)
    font(roboto)
    freeorion-data
    hicolor-icon-theme
    ld-linux-x86-64.so.2()(64bit)
    libGL.so.1()(64bit)
    libGLEW.so.2.1()(64bit)
    libGiGi.so()(64bit)
    libSDL2-2.0.so.0()(64bit)
    libboost_filesystem.so.1.73.0()(64bit)
    libboost_iostreams.so.1.73.0()(64bit)
    libboost_locale.so.1.73.0()(64bit)
    libboost_log.so.1.73.0()(64bit)
    libboost_log_setup.so.1.73.0()(64bit)
    libboost_python39.so.1.73.0()(64bit)
    libboost_regex.so.1.73.0()(64bit)
    libboost_serialization.so.1.73.0()(64bit)
    libboost_thread.so.1.73.0()(64bit)
    libc.so.6()(64bit)
    libfreeorioncommon.so()(64bit)
    libfreeorionparse.so()(64bit)
    libfreetype.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgcc_s.so.1(GCC_3.4)(64bit)
    libm.so.6()(64bit)
    libopenal.so.1()(64bit)
    libpng16.so.16()(64bit)
    libpng16.so.16(PNG16_0)(64bit)
    libpthread.so.0()(64bit)
    libpython3.9.so.1.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.1)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libvorbis.so.0()(64bit)
    libvorbisfile.so.3()(64bit)
    rtld(GNU_HASH)

freeorion-data (rpmlib, GLIBC filtered):

freeorion-debuginfo (rpmlib, GLIBC filtered):

freeorion-debugsource (rpmlib, GLIBC filtered):



Provides
--------
freeorion:
    application()
    application(org.freeorion.FreeOrion.desktop)
    freeorion
    freeorion(x86-64)
    libGiGi.so()(64bit)
    libfreeorioncommon.so()(64bit)
    libfreeorionparse.so()(64bit)
    metainfo()
    metainfo(freeorion.appdata.xml)
    metainfo(org.freeorion.FreeOrion.metainfo.xml)

freeorion-data:
    freeorion-data

freeorion-debuginfo:
    debuginfo(build-id)
    freeorion-debuginfo
    freeorion-debuginfo(x86-64)

freeorion-debugsource:
    freeorion-debugsource
    freeorion-debugsource(x86-64)



Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1881183
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Java, Haskell, R, PHP, fonts, Perl, Python, Ocaml,
SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux